Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-label PRs by outside collaborators #648

Merged

Conversation

andrewsavage1
Copy link
Contributor

@andrewsavage1 andrewsavage1 commented Jun 15, 2023

b/261052420

@andrewsavage1
Copy link
Contributor Author

@lamdbui it would be good to hear what we want this to look like—whether it should be auto-assignment, a label automatically applied to the PR, or something else entirely

@andrewsavage1 andrewsavage1 changed the title Auto-assign outisde PRs to partner-eng Auto-label PRs by outside collaborators Jun 28, 2023
@andrewsavage1
Copy link
Contributor Author

See an example here: youtube/cobalt_sandbox#467

@andrewsavage1 andrewsavage1 force-pushed the feature/automatic-peng-assignment branch from 47d9ae7 to 23b80db Compare June 28, 2023 13:46
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #648 (23b80db) into main (f97ba09) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   56.51%   56.50%   -0.02%     
==========================================
  Files        1897     1897              
  Lines       94217    94217              
==========================================
- Hits        53247    53236      -11     
- Misses      40970    40981      +11     

see 2 files with indirect coverage changes

@kaidokert
Copy link
Member

@lamdbui it would be good to hear what we want this to look like—whether it should be auto-assignment, a label automatically applied to the PR, or something else entirely

I'd start with a label, as it is now. Easy to make a go-link that just shows pending ones.

@kaidokert
Copy link
Member

Quick ping on this - seems like a good thing to land. @lamdbui

@lamdbui
Copy link

lamdbui commented Aug 2, 2023

Sorry it took a while for me to get to this. Yes, a label sounds great. As long as we have an on-going process for review with say a go/ link as @kaidokert mentioned, we can track this. If we find that we need an alias or something, we can add it later, but let's keep it simple for now.

@andrewsavage1 andrewsavage1 marked this pull request as ready for review August 7, 2023 19:22
@andrewsavage1 andrewsavage1 merged commit d6d6554 into youtube:main Aug 7, 2023
6 of 8 checks passed
@andrewsavage1 andrewsavage1 deleted the feature/automatic-peng-assignment branch August 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants